Skip to content

Conversation

@changliiu
Copy link
Contributor

@changliiu changliiu commented Jun 30, 2025

run bomupgrader.py to update Google Cloud-related dependency

According to https://github.com/apache/beam/blob/master/contributor-docs/java-dependency-upgrades.md to update google related dependency versions.

Command I ran - "python scripts/tools/bomupgrader.py 26.62.0"

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@changliiu
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @Abacn for label java.
R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Jun 30, 2025

please check the failed test

testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed

 but: The following disallowed classes appeared on the API surface:
	interface com.google.errorprone.annotations.CheckReturnValue exposed via:
		interface com.google.errorprone.annotations.CheckReturnValue

to fix, add "com.google.errorprone.annotations.CheckReturnValue" to

@changliiu
Copy link
Contributor Author

please check the failed test

testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed

 but: The following disallowed classes appeared on the API surface:
	interface com.google.errorprone.annotations.CheckReturnValue exposed via:
		interface com.google.errorprone.annotations.CheckReturnValue

to fix, add "com.google.errorprone.annotations.CheckReturnValue" to

Done. PTAL thanks!

@Abacn
Copy link
Contributor

Abacn commented Jun 30, 2025

Done. PTAL thanks!

Sorry if it wasn't clear. It is

Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),

not classesInPackage matchers. The latter was for packages. And the test will pass (checked locally)

checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1

@changliiu changliiu force-pushed the upgrade_dependency branch from 6938e4f to 328b200 Compare June 30, 2025 21:18
@changliiu
Copy link
Contributor Author

Done. PTAL thanks!

Sorry if it wasn't clear. It is

Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),

not classesInPackage matchers. The latter was for packages. And the test will pass (checked locally)

checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1

Done. Thanks so much for the instructions.

@Abacn Abacn merged commit ffb359c into apache:master Jul 1, 2025
24 of 25 checks passed
@changliiu changliiu deleted the upgrade_dependency branch July 1, 2025 16:10
changliiu added a commit to changliiu/beam that referenced this pull request Jul 1, 2025
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jul 1, 2025
Amar3tto added a commit that referenced this pull request Jul 11, 2025
Amar3tto added a commit that referenced this pull request Jul 15, 2025
@kennknowles
Copy link
Member

Was the downgrade of netty required here? We would like to be at least on the version 118 final as it was before.

@Abacn
Copy link
Contributor

Abacn commented Sep 24, 2025

It got reverted by the tool due to GCP-BOM version was older. For GCP-BOM managed dependencies we generally avoid pin its versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants