-
Notifications
You must be signed in to change notification settings - Fork 4.5k
run bomupgrader.py to update Google Cloud-related dependency #35480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
please check the failed test to fix, add "com.google.errorprone.annotations.CheckReturnValue" to Line 63 in 510d842
|
01ccad2 to
da45dc8
Compare
da45dc8 to
3b3e2a2
Compare
Done. PTAL thanks! |
3b3e2a2 to
6938e4f
Compare
Sorry if it wasn't clear. It is not checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1 |
6938e4f to
328b200
Compare
Done. Thanks so much for the instructions. |
|
Was the downgrade of netty required here? We would like to be at least on the version 118 final as it was before. |
|
It got reverted by the tool due to GCP-BOM version was older. For GCP-BOM managed dependencies we generally avoid pin its versions |
run bomupgrader.py to update Google Cloud-related dependency
According to https://github.com/apache/beam/blob/master/contributor-docs/java-dependency-upgrades.md to update google related dependency versions.
Command I ran - "python scripts/tools/bomupgrader.py 26.62.0"