Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Jul 8, 2025

Reverts #34167
Fixes #34855
Successful run: https://github.com/apache/beam/actions/runs/16148394681


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto Amar3tto requested a review from damccorm July 8, 2025 16:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Assigning reviewers:

R: @liferoad added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just fix the import instead? It looks like we can just change require("@octokit/rest"); to import { Octokit } from "@octokit/rest";

We likely would need to do this for all imported modules using require, but it should be a pretty straightforward fix and will allow us to keep this dependency up to date

@Amar3tto
Copy link
Collaborator Author

Amar3tto commented Jul 9, 2025

Closing this, new PR: #35545

@Amar3tto Amar3tto closed this Jul 9, 2025
@Amar3tto Amar3tto deleted the fix-generate-issue-report branch July 11, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Generate issue report job is flaky

2 participants