Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Jul 21, 2025

Addresses #35637

These changes allow the following:

  • CREATE DATABASE ( IF NOT EXISTS )? database_name
  • USE DATABASE database_name
  • DROP DATABASE [ IF EXISTS ] database_name [ RESTRICT | CASCADE ]
    • RESTRICT (default) will throw an error if the database contains a table. CASCADE will drop all tables within the database before dropping the database.

For Iceberg catalogs, CREATE and DROP will create/drop real external tables in the appropriate data platform.

These implementations will help bring Beam closer to alignment with existing Flink and Spark syntax

@ahmedabu98
Copy link
Contributor Author

cc @talatuyarer

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor Author

R: @tarun-google

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@tarun-google tarun-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Great work fixing gap in Iceberg Beam SQL

@ahmedabu98 ahmedabu98 merged commit ae62943 into apache:master Jul 22, 2025
23 checks passed
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (ce77091) to head (17993a3).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #35641   +/-   ##
=========================================
  Coverage     56.54%   56.54%           
  Complexity     3382     3382           
=========================================
  Files          1205     1205           
  Lines        183856   183856           
  Branches       3477     3477           
=========================================
  Hits         103961   103961           
  Misses        76577    76577           
  Partials       3318     3318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants