-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Beam SQL] Support DATABASE concept in Beam SQL, with implementation for Iceberg #35641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @talatuyarer |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
...ions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlCreateDatabase.java
Outdated
Show resolved
Hide resolved
tarun-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Great work fixing gap in Iceberg Beam SQL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35641 +/- ##
=========================================
Coverage 56.54% 56.54%
Complexity 3382 3382
=========================================
Files 1205 1205
Lines 183856 183856
Branches 3477 3477
=========================================
Hits 103961 103961
Misses 76577 76577
Partials 3318 3318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Addresses #35637
These changes allow the following:
CREATE DATABASE ( IF NOT EXISTS )? database_nameUSE DATABASE database_nameDROP DATABASE [ IF EXISTS ] database_name [ RESTRICT | CASCADE ]RESTRICT(default) will throw an error if the database contains a table.CASCADEwill drop all tables within the database before dropping the database.For Iceberg catalogs,
CREATEandDROPwill create/drop real external tables in the appropriate data platform.These implementations will help bring Beam closer to alignment with existing Flink and Spark syntax