Skip to content

Conversation

@mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Jul 25, 2025

Description

Given that we have support for pytest user markers (#35655), we can extend this functionality to our post/pre commit workflows targeting ML tests on the first iteration mainly for Milvus itests.

Motivation and Context

#35585

#35598 (reverted because pytest user markers wasn't allowed back then)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@github-actions github-actions bot added the build label Jul 25, 2025
@mohamedawnallah mohamedawnallah force-pushed the ubuntu-latest-on-postcommit-python-and-ml branch 2 times, most recently from 48c4bb0 to 2a1ef8f Compare July 25, 2025 19:51
@mohamedawnallah
Copy link
Contributor Author

cc: @damccorm

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Jul 25, 2025

I think missed the matrix on the workflow job. Resolving them now...

In this commit, we run ML tests requiring
docker-in-docker environment on `ubuntu-latest`. The
motivation behind this is Milvus itests was requiring
docker-in-docker environment due to setup issues on
beam CI self-hosted environment.
@mohamedawnallah mohamedawnallah force-pushed the ubuntu-latest-on-postcommit-python-and-ml branch from 2a1ef8f to a71dc4f Compare July 25, 2025 20:03
@mohamedawnallah
Copy link
Contributor Author

I think missed the matrix on the workflow job. Resolving them now...

Resolved them. I think PR now ready for review

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can try this out

@damccorm damccorm merged commit e2a3ab8 into apache:master Jul 29, 2025
4 checks passed
@liferoad
Copy link
Contributor

https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml?query=branch%3Amaster looks perm-red now.

@mohamedawnallah

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants