sdks/python/scripts: capture (...) pytest marker group

[mohamedawnallah]

Description

Fix failed testcases for beam_PreCommit_Python_ML and beam_PostCommit_Python workflows. Kicked off in #35733 (comment).

Change State Analysis

Before	After

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @mohamedawnallah, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the run_pytest.sh script within the Python SDKs to enhance its ability to parse pytest marker arguments. This change specifically allows the script to correctly capture pytest marker groups that are enclosed in parentheses, improving the flexibility of test execution commands. A minor, unrelated change was also made to a GitHub trigger file.

Highlights

• Pytest Marker Regex Enhancement: I've modified the marker_regex in sdks/python/scripts/run_pytest.sh to correctly capture pytest marker groups that include parentheses, such as (-m 'group1 and (group2 or group3)'). This enhances the script's ability to parse complex marker arguments.
• CI Trigger Update: A small, non-functional update was made to .github/trigger_files/beam_PostCommit_Python.json, likely to trigger CI builds.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the run_pytest.sh script to better capture pytest marker expressions, specifically those enclosed in parentheses. The change modifies the regular expression used to extract the marker. While this improves handling for simple parenthesized markers, I've identified a potential issue with the new regex where it doesn't correctly handle nested parentheses, which could lead to incorrect test selection for complex marker expressions. My review includes a detailed comment on this issue.

[mohamedawnallah]

One of ML related tests passed 🎉
https://github.com/apache/beam/actions/runs/16626460814/job/47044190629?pr=35740

[github-actions]

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[shunping]

This looks promising. All Precommit ML test have passed now.

[damccorm]

Thanks! I think the postcommit failures are actually due to flaky tests

[mohamedawnallah]

Thanks! I think the postcommit failures are actually due to flaky tests

@damccorm - I've just checked the postcommits now (https://github.com/apache/beam/actions/runs/16626460845/job/47044172409) they seem fail with:

2025-07-30T17:12:38.8100559Z * What went wrong:
2025-07-30T17:12:38.8100937Z Execution failed for task ':sdks:python:test-suites:direct:py39:dockerInDockerIntegrationTest'.
2025-07-30T17:12:38.8101406Z > Process 'command 'sh'' finished with non-zero exit value 5

It is related to this part:

beam/sdks/python/test-suites/direct/common.gradle

Lines 422 to 447 in 72ecb47

	// Integration tests that require Docker-in-Docker capabilities.
	// These tests are marked with the `require_docker_in_docker` pytest marker
	// because they rely on Docker-in-Docker configurations that are not supported
	// on Beam's self-hosted GitHub Actions runners. Docker-in-Docker works on
	// ubuntu-latest GitHub-hosted runners but not on self-hosted environments due
	// to containerization architecture differences.
	// Context: https://github.com/apache/beam/pull/35585
	task dockerInDockerIntegrationTest {
	dependsOn 'installGcpTest'
	dependsOn ':sdks:python:sdist'
	doLast {
	def testOpts = basicTestOpts
	def argMap = [
	"test_opts": testOpts,
	"suite": "postCommitIT-direct-py${pythonVersionSuffix}",
	"collect": "require_docker_in_docker",
	"runner": "TestDirectRunner",
	]
	def cmdArgs = mapToArgString(argMap)
	exec {
	executable 'sh'
	args '-c', ". ${envdir}/bin/activate && ${runScriptsDir}/run_integration_test.sh $cmdArgs"
	}
	}
	}

I will investigate what was the issue actually and come up with a patch for this

if it is urgent I think we can temporarily remove dockerInDockerIntegrationTest from here:

beam/sdks/python/test-suites/direct/common.gradle

Lines 449 to 464 in d493275

	// Add all the RunInference framework IT tests to this gradle task that runs on Direct Runner Post commit suite.
	project.tasks.register("inferencePostCommitIT") {
	dependsOn = [
	'torchInferenceTest',
	'sklearnInferenceTest',
	'tensorflowInferenceTest',
	'xgboostInferenceTest',
	'transformersInferenceTest',
	'testcontainersTest',
	'feastIntegrationTest',
	'dockerInDockerIntegrationTest',
	// (TODO) https://github.com/apache/beam/issues/25799
	// uncomment tfx bsl tests once tfx supports protobuf 4.x
	// 'tfxInferenceTest',
	]
	}

[tvalentyn]

Hi @mohamedawnallah - which tool did you use to visualize the regex in the description? Looks neat.

[mohamedawnallah]

Hi @mohamedawnallah - which tool did you use to visualize the regex in the description? Looks neat.

I used this one https://regexper.com/

[tvalentyn]

thanks!