[#35869] [Go SDK] Fix Duplicated elements on Blind Writes to Bag State. #35870
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @lostluck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the Go SDK where "blind writes" to Bag State could lead to duplicated elements. The fix involves performing an eager read of the Bag State before writing to it, ensuring that the state is properly initialized and preventing spurious duplicates. While this approach is less efficient than the batching mechanisms in other SDKs, it provides an immediate solution to the data duplication issue.
Highlights
- Go SDK Bag State Fix: Implemented an eager read mechanism within the WriteBagState function in userstate.go. Before appending to the bag, the system now checks if an initial read has occurred; if not, it performs one to prevent data duplication issues arising from blind writes.
- New Integration Test for Blind Writes: Added a new integration test, BagStateBlindWriteParDo, in sdks/go/test/integration/primitives/state.go and state_test.go. This test specifically validates the correct behavior of bag state when writes occur without a preceding read, ensuring the fix effectively prevents element duplication.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
lostluck
changed the title
|
Assigning reviewers: R: @jrmccluskey for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks! |
…g State. (apache#35870) * [GoSDK] Add blind write test for BagState. * Hack a quick fix. to the Bag state Blind write issue. * Avoid extra read instead. * Add CHANGES.md entry. * ws lint * Touch up test, add commentary. Clean up printlns. --------- Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
2 participants
Track blind writes before the first read to avoid spurious duplicated elements on re-applying the transactions.
Fixes #35869
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.