-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Postrelease-2.67] Remove mysql-connector-python dependency #35933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on streamlining the project's Python dependencies by removing the mysql-connector-python package. This change impacts the core test dependencies, as well as the build requirements for various Python container images. The rationale appears to be that this specific connector is no longer needed, especially where sqlalchemy is used with the pymysql dialect for MySQL connections, thereby reducing the overall dependency footprint and potential conflicts.
Highlights
- Dependency Removal from setup.py: The
mysql-connector-pythondependency has been removed from the mainsetup.pyfile, specifically from theBEAM_REQUIRED_TEST_PACKAGESlist. - Dependency Removal from Container Requirements: The
mysql-connector-pythondependency has been removed from allbase_image_requirements.txtandml_image_requirements.txtfiles across Python versions 3.9, 3.10, 3.11, and 3.12. This streamlines the build environments for various Python versions. - Refactoring of MySQL Test Connections: The
sdks/python/apache_beam/yaml/integration_tests.pyfile was updated to remove the direct import ofmysql.connectorand its associated error handling. The tests now solely rely onsqlalchemywith thepymysqldialect for MySQL interactions, indicating thatmysql-connector-pythonwas not necessary for these test cases.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
outdated test; not related to the change |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.67.0-postrelease #35933 +/- ##
=============================================================
Coverage ? 56.56%
Complexity ? 3381
=============================================================
Files ? 1204
Lines ? 183787
Branches ? 3490
=============================================================
Hits ? 103965
Misses ? 76496
Partials ? 3326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I agree it is not related to this change. But it is a hard fail, so what is up with that? |
This also existed on the RC PR - #35795 (comment) The underlying cause was pinning to incompatible dependency versions in our tests, and was fixed by #35819 We didn't cherry-pick the commit since it was test only and RC2 was otherwise ready (it would've been good to include that info on the PR though, that was a miss) |
74cb870
into
apache:release-2.67.0-postrelease
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.