Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 21, 2025

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the project's Python dependencies by removing the mysql-connector-python package. This change impacts the core test dependencies, as well as the build requirements for various Python container images. The rationale appears to be that this specific connector is no longer needed, especially where sqlalchemy is used with the pymysql dialect for MySQL connections, thereby reducing the overall dependency footprint and potential conflicts.

Highlights

  • Dependency Removal from setup.py: The mysql-connector-python dependency has been removed from the main setup.py file, specifically from the BEAM_REQUIRED_TEST_PACKAGES list.
  • Dependency Removal from Container Requirements: The mysql-connector-python dependency has been removed from all base_image_requirements.txt and ml_image_requirements.txt files across Python versions 3.9, 3.10, 3.11, and 3.12. This streamlines the build environments for various Python versions.
  • Refactoring of MySQL Test Connections: The sdks/python/apache_beam/yaml/integration_tests.py file was updated to remove the direct import of mysql.connector and its associated error handling. The tests now solely rely on sqlalchemy with the pymysql dialect for MySQL interactions, indicating that mysql-connector-python was not necessary for these test cases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn Abacn changed the title Remove mysql-connector-python dependency [Postrelease-2.67] Remove mysql-connector-python dependency Aug 21, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Aug 21, 2025

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn
Copy link
Contributor Author

Abacn commented Aug 21, 2025

apache_beam/yaml/integration_tests.py::RuninferenceTest::test_only - google.api_core.exceptions.PermissionDenied: 403 Tuned endpoint is blocked because publisher model `projects/844138762903/locations/us-central1/publishers/google/models/text-bison@001` 

outdated test;

ModuleNotFoundError: No module named 'transformers'

not related to the change

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.67.0-postrelease@ab2b8d3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
sdks/python/apache_beam/yaml/integration_tests.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             release-2.67.0-postrelease   #35933   +/-   ##
=============================================================
  Coverage                              ?   56.56%           
  Complexity                            ?     3381           
=============================================================
  Files                                 ?     1204           
  Lines                                 ?   183787           
  Branches                              ?     3490           
=============================================================
  Hits                                  ?   103965           
  Misses                                ?    76496           
  Partials                              ?     3326           
Flag Coverage Δ
python 80.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kennknowles
Copy link
Member

I agree it is not related to this change. But it is a hard fail, so what is up with that?

@damccorm
Copy link
Contributor

I agree it is not related to this change. But it is a hard fail, so what is up with that?

This also existed on the RC PR - #35795 (comment)

The underlying cause was pinning to incompatible dependency versions in our tests, and was fixed by #35819

We didn't cherry-pick the commit since it was test only and RC2 was otherwise ready (it would've been good to include that info on the PR though, that was a miss)

@kennknowles kennknowles merged commit 74cb870 into apache:release-2.67.0-postrelease Aug 22, 2025
117 of 131 checks passed
@Abacn Abacn deleted the cp-35932 branch September 9, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants