Skip to content

Conversation

@mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Aug 25, 2025

Motivation and Context

Addresses #35920 (comment)

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added the build label Aug 25, 2025
@mohamedawnallah mohamedawnallah force-pushed the captureDinDTestsinPreCommitPythonCoverage branch from 6945b23 to 23a1a33 Compare August 25, 2025 20:23
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Aug 25, 2025

Hey @damccorm, I think this PR would solve this issue #35920 (comment). It turned out that ML tests run also in that workflow beam_PreCommit_Python_Coverage so we need to add the filtering for tests that require_docker_in_docker i.e Milvus tests

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Aug 25, 2025

Thanks - trying this here - https://github.com/apache/beam/actions/runs/17220391007

The tests beam_PreCommit_Python_Coverage running on ubuntu-latest variant exits with code value 5 which indicates no tests to run. This due to the fact (as yet) Milvus dependencies not added properly (existing follow-up PR #35920) so the tests with pytest marker require_docker_in_docker are skipped

SKIPPED [1] apache_beam/ml/rag/enrichment/milvus_search_it_test.py:72: unittest.case.SkipTest: Milvus dependencies not installed: No module named 'pymilvus'

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Aug 25, 2025

Removing now the ubuntu-latest from beam_PreCommit_Python_Coverage since we're gonna add it later in this PR #35816

beam_PreCommit_Python_Coverage:
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
runs-on: [self-hosted, ubuntu-20.04, highmem]
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of including python_version, could we include the os? That way the generated job names will be different per job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of including python_version, could we include the os? That way the generated job names will be different per job

Added OS label to workflow (job_name and test results). Perhaps we can leave the python_version since this workflow currently runs on the default python version which is 3.9 in future potentially this can run on multiple python versions?

@mohamedawnallah
Copy link
Contributor Author

Hey @damccorm, can you please take another look? I have removed Pposargs from this PR as per this comment #35954 (comment)

@mohamedawnallah
Copy link
Contributor Author

Cherry-picking those commits in that PR #35920. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants