Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Sep 4, 2025

Managed JDBCIO (Part 3) - SqlServer

Similar to #36034 and #36045

@shunping shunping self-assigned this Sep 22, 2025
@shunping shunping marked this pull request as ready for review September 22, 2025 02:48
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @tvalentyn for label python.
R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just a couple comments

side note -- We should look into an abstract testing class for these. There's a lot of boiler plate that can be cleaned up here

@shunping
Copy link
Collaborator Author

side note -- We should look into an abstract testing class for these. There's a lot of boiler plate that can be cleaned up here

ACK

@shunping shunping merged commit 527e821 into apache:master Sep 24, 2025
124 of 139 checks passed
@shunping shunping deleted the managed-jdbcio-4 branch September 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants