Cherry pick #35981 #36079
Cherry pick #35981 #36079
Conversation
* update iceberg to 1.9.2 * cleanup * move iceberg sql into a separate module * check test java version too * cleanup * spotless * deps * add missing dep * block java 8 * create examples/iceberg module * dep fixes * import fixes * test fix * update changes * update changes * include integration tests * add examples:iceberg to javaPreCommit * fix deps * fix deps
|
R: @Amar3tto |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ahmedabu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on upgrading the Apache Iceberg dependency to its latest version and restructuring the project's modules to accommodate the new Java 11+ requirement for Iceberg-related components. This ensures compatibility with modern Iceberg features while managing the impact on the overall Java version support.
Highlights
- Iceberg Dependency Upgrade: The Apache Iceberg dependency has been upgraded to version 1.9.2, bringing the project up to date with the latest features and improvements from the Iceberg community.
- Java 8 Support Dropped for Iceberg-related Components: Due to the Iceberg dependency upgrade, Java 8 support has been dropped for the Iceberg IO expansion-service and other Iceberg-related modules. Cross-language pipelines utilizing these components will now require a Java 11+ runtime environment.
- Module Refactoring for Iceberg Examples and SQL Extensions: Iceberg-related examples and SQL extensions have been refactored into new, dedicated Gradle modules (
examples:java:icebergandsdks:java:extensions:sql:iceberg). This change isolates the Java 11+ requirement to these specific modules, allowing other parts of the codebase to maintain broader Java compatibility.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
actually, it may break Iceberg test in Beam YAML: https://github.com/apache/beam/actions/runs/17520896047/job/49764503326 |
|
Okay to merge this along with CP for the fix (#36097) ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.68 #36079 +/- ##
===============================================
Coverage ? 56.79%
Complexity ? 3385
===============================================
Files ? 1220
Lines ? 185120
Branches ? 3508
===============================================
Hits ? 105146
Misses ? 76649
Partials ? 3325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
#35981