Skip to content

Conversation

@liferoad
Copy link
Contributor

@liferoad liferoad commented Sep 9, 2025

Fixes #35198

025-09-09T17:57:22.3193168Z =========================== short test summary info ============================
2025-09-09T17:57:22.3194694Z FAILED apache_beam/yaml/integration_tests.py::PostgresTest::test_only - ValueError: Error applying transform "WriteToPostgres" at line 33: java.lang.IllegalArgumentException: Wrong JDBC type. Expected 'postgres' but got ''
2025-09-09T17:57:22.3196717Z 	at org.apache.beam.sdk.io.jdbc.providers.WriteToPostgresSchemaTransformProvider.from(WriteToPostgresSchemaTransformProvider.java:63)
2025-09-09T17:57:22.3198431Z 	at org.apache.beam.sdk.io.jdbc.providers.WriteToPostgresSchemaTransformProvider.from(WriteToPostgresSchemaTransformProvider.java:36)
2025-09-09T17:57:22.3200284Z 	at org.apache.beam.sdk.schemas.transforms.TypedSchemaTransformProvider.from(TypedSchemaTransformProvider.java:111)
2025-09-09T17:57:22.3202104Z 	at org.apache.beam.sdk.expansion.service.ExpansionServiceSchemaTransformProvider.getTransform(ExpansionServiceSchemaTransformProvider.java:137)
2025-09-09T17:57:22.3203904Z 	at org.apache.beam.sdk.expansion.service.ExpansionService$TransformProviderForPayloadTranslator.getTransform(ExpansionService.java:263)
2025-09-09T17:57:22.3205314Z 	at org.apache.beam.sdk.expansion.service.TransformProvider.apply(TransformProvider.java:121)
2025-09-09T17:57:22.3206436Z 	at org.apache.beam.sdk.expansion.service.ExpansionService.expand(ExpansionService.java:657)
2025-09-09T17:57:22.3207518Z 	at org.apache.beam.sdk.expansion.service.ExpansionService.expand(ExpansionService.java:758)
2025-09-09T17:57:22.3208770Z 	at org.apache.beam.model.expansion.v1.ExpansionServiceGrpc$MethodHandlers.invoke(ExpansionServiceGrpc.java:306)
2025-09-09T17:57:22.3210315Z 	at org.apache.beam.vendor.grpc.v1p69p0.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
2025-09-09T17:57:22.3212054Z 	at org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:356)
2025-09-09T17:57:22.3213774Z 	at org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:861)
2025-09-09T17:57:22.3215505Z 	at org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
2025-09-09T17:57:22.3216814Z 	at org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
2025-09-09T17:57:22.3218012Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2025-09-09T17:57:22.3219129Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2025-09-09T17:57:22.3219926Z 	at java.base/java.lang.Thread.run(Thread.java:829)
2025-09-09T17:57:22.3220360Z 
2025-09-09T17:57:22.3220369Z 
2025-09-09T17:57:22.3220855Z java.lang.IllegalArgumentException: Wrong JDBC type. Expected 'postgres' but got ''

https://productionresultssa0.blob.core.windows.net/actions-results/a9bd2633-9ccb-4bb2-8ccf-21615d49b6d6/workflow-job-run-0f8530dd-c0d8-5110-bc4c-cd0b75d084b9/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-09-09T18%3A54%3A01Z&sig=y0KMBQT0dBpYy99Lm4COR1H3wPjUHpuRnN9%2B0UtW7e0%3D&ske=2025-09-10T06%3A20%3A17Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-09-09T18%3A20%3A17Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-09-09T18%3A43%3A56Z&sv=2025-05-05


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the JDBC type validation for Postgres connectors. Previously, an empty string provided for the jdbcType parameter would bypass the null check but still cause an IllegalArgumentException. The fix ensures that empty strings are now correctly identified and rejected, improving the robustness of the data pipeline's interaction with Postgres databases.

Highlights

  • JDBC Type Validation Fix: Enhanced the JDBC type validation logic for both reading from and writing to Postgres. The change specifically adds a check to ensure that the jdbcType parameter is not an empty string, preventing IllegalArgumentException when an empty string is provided instead of null or a valid type.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Collaborator

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Assigning reviewers:

R: @m-trieu for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping merged commit 9651c64 into apache:master Sep 9, 2025
16 checks passed
@Amar3tto
Copy link
Collaborator

Amar3tto commented Sep 9, 2025

Let's cherrypick this to release-2.68

@liferoad
Copy link
Contributor Author

liferoad commented Sep 9, 2025

Let's cherrypick this to release-2.68

I do not think we need this for 2.68 since #36034 was merged after the cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit YAML Xlang Direct job is flaky

4 participants