Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

Reverts #35981 and #36092

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ahmedabu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to stabilize the project by reverting a recent dependency upgrade that introduced compatibility challenges. It specifically downgrades the Apache Iceberg dependency and restores Java 8 support for a critical component. The changes also involve a significant restructuring of the codebase, integrating previously separate modules directly into their parent projects to simplify maintenance and improve overall consistency.

Highlights

  • Iceberg Version Downgrade: This pull request reverts the Apache Iceberg dependency from version 1.9.2 back to 1.6.1, addressing potential compatibility issues introduced by the newer version.
  • Java 8 Compatibility Restoration: Java 8 support for the Beam IO expansion service has been re-enabled. The previous upgrade to Iceberg 1.9.2 had dropped this support, which is now restored.
  • Module Consolidation and Refactoring: Dedicated Gradle modules for Iceberg examples (examples/java/iceberg) and the SQL extension (sdks/java/extensions/sql:iceberg) have been removed. Their contents, including examples and core SQL extension components, have been moved and integrated directly into the general examples/java and sdks/java/extensions/sql modules, respectively. This streamlines the project structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chamikaramj
Copy link
Contributor

LGTM.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto
Copy link
Collaborator

Should we also cherrypick this to release-2.68 ?

@chamikaramj
Copy link
Contributor

chamikaramj commented Sep 10, 2025

This shouldn't be needed since we have a workaround in #36108.

@ahmedabu98 ahmedabu98 closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants