Skip to content

Conversation

@liferoad
Copy link
Contributor

The AppliedPTransform initialization previously accessed transform.side_inputs directly. This could lead to an AttributeError if a transform object did not have a side_inputs attribute.

This change uses getattr to safely access the attribute, providing an empty tuple as a default value. This makes the pipeline construction more robust by preventing crashes for transforms that do not define side inputs.

Fixes #33854


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

The AppliedPTransform initialization previously accessed `transform.side_inputs` directly. This could lead to an `AttributeError` if a transform object did not have a `side_inputs` attribute.

This change uses `getattr` to safely access the attribute, providing an empty tuple as a default value. This makes the pipeline construction more robust by preventing crashes for transforms that do not define side inputs.
@liferoad liferoad requested a review from claudevdm September 23, 2025 00:30
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the pipeline construction process by addressing a potential AttributeError during the initialization of AppliedPTransform. It ensures that transforms without explicitly defined side inputs are handled gracefully, preventing crashes and improving overall stability.

Highlights

  • Robustness in pipeline construction: The AppliedPTransform initialization now safely accesses transform.side_inputs using getattr, preventing AttributeError if the side_inputs attribute is missing. It defaults to an empty tuple, making the pipeline more resilient.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.92%. Comparing base (d26dbac) to head (298483e).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36238      +/-   ##
============================================
- Coverage     54.93%   54.92%   -0.01%     
  Complexity     1617     1617              
============================================
  Files          1057     1057              
  Lines        164425   164395      -30     
  Branches       1165     1165              
============================================
- Hits          90320    90293      -27     
+ Misses        71955    71953       -2     
+ Partials       2150     2149       -1     
Flag Coverage Δ
python 80.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liferoad liferoad merged commit 757ffcd into apache:master Sep 23, 2025
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: AttributeError for MaybeReshuffle in Python SDK

2 participants