Fix JUnit 5 module

[Abacn]

The module wasn't functioning. The test was not exercised (and actually would fail)

• Revert TestPipeline change in JUnit5 support #35688 and move shared logic into package-private methods

• Remove TestPipeline private member in Extension. It messed up with Context store.

• Exercise tests on precommit

• Publish javadoc

#35688 was likely AI authored and was incomplete

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where the JUnit 5 testing module was not functioning correctly and its associated tests were not being executed. The changes ensure that the JUnit 5 module's tests are now part of the precommit build process and that its javadoc is published. Key refactorings in TestPipeline and TestPipelineExtension improve the robustness and correctness of JUnit 5 test execution by enhancing how pipeline options are managed and how test enforcements are applied, ultimately making the testing framework more reliable.

Highlights

• JUnit 5 Module Functionality: The JUnit 5 testing module, which was previously non-functional and had its tests unexercised, has been fixed to ensure proper operation.
• Precommit Test Execution: The tests for the JUnit 5 module are now integrated into the javaPreCommit task, ensuring they are automatically run and validated before code is committed.
• Javadoc Publication Enabled: Javadoc generation and publication have been enabled for the JUnit 5 module, improving documentation availability.
• TestPipeline Refactoring: The TestPipeline class has been refactored to expose package-private methods for handling enforcement level deduction and post-test cleanup, facilitating better integration with JUnit 5 extensions.
• TestPipelineExtension Update: The TestPipelineExtension has been updated to utilize the new refactored methods in TestPipeline, streamlining its logic for pipeline setup, enforcement, and teardown in JUnit 5 tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.82%. Comparing base (17c8515) to head (4c34953).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #36258   +/-   ##
=========================================
  Coverage     56.82%   56.82%           
- Complexity     3386     3387    +1     
=========================================
  Files          1220     1220           
  Lines        185731   185731           
  Branches       3523     3523           
=========================================
  Hits         105538   105538           
  Misses        76853    76853           
  Partials       3340     3340           

Flag	Coverage Δ
java	70.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[Abacn]

R: @damccorm

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[damccorm]

Thanks!