Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 3, 2025

#36333 incidentally regressed ML tests because:

  1. These tests previously couldn't run on Prism because of a trigger type. This unsupported capability was removed in [Prism] Support AfterProcessingTime triggers - part 2 #36333
  2. These tests assumed they'd receive a value error, but portable pipelines raise RuntimeErrors always

This should fix the problem


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 3, 2025
@damccorm
Copy link
Contributor Author

damccorm commented Oct 3, 2025

R: @shunping

@damccorm damccorm marked this pull request as ready for review October 3, 2025 15:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.20%. Comparing base (3534960) to head (50738af).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36377      +/-   ##
============================================
- Coverage     40.20%   40.20%   -0.01%     
  Complexity     3386     3386              
============================================
  Files          1220     1220              
  Lines        186149   186174      +25     
  Branches       3523     3523              
============================================
+ Hits          74839    74849      +10     
- Misses       107955   107970      +15     
  Partials       3355     3355              
Flag Coverage Δ
python 40.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm
Copy link
Contributor Author

damccorm commented Oct 3, 2025

Also added #36378 for future proofing

@shunping
Copy link
Collaborator

shunping commented Oct 3, 2025

Thanks for fixing that. Any other breaking tests due to prism supporting processing time trigger?

@damccorm
Copy link
Contributor Author

damccorm commented Oct 3, 2025

This is all I've seen so far

@damccorm damccorm merged commit bd5cfda into master Oct 3, 2025
104 of 108 checks passed
@damccorm damccorm deleted the users/damccorm/portableTest branch October 3, 2025 17:13
@lostluck
Copy link
Contributor

lostluck commented Oct 3, 2025

This is the best kind of regression. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants