-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Make ml tests portable #36377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ml tests portable #36377
Conversation
|
R: @shunping |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36377 +/- ##
============================================
- Coverage 40.20% 40.20% -0.01%
Complexity 3386 3386
============================================
Files 1220 1220
Lines 186149 186174 +25
Branches 3523 3523
============================================
+ Hits 74839 74849 +10
- Misses 107955 107970 +15
Partials 3355 3355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also added #36378 for future proofing |
|
Thanks for fixing that. Any other breaking tests due to prism supporting processing time trigger? |
|
This is all I've seen so far |
|
This is the best kind of regression. :D |
#36333 incidentally regressed ML tests because:
This should fix the problem
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.