-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add labels to unlabeled transforms #36381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the clarity and debuggability of Apache Beam pipelines by systematically applying explicit labels to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
For a reviewer - please fact check that I got the line numbers right based on the release-2.68 branch and the file names right. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36381 +/- ##
============================================
- Coverage 40.20% 40.20% -0.01%
Complexity 3386 3386
============================================
Files 1220 1220
Lines 186149 186175 +26
Branches 3523 3523
============================================
+ Hits 74839 74843 +4
- Misses 107955 107977 +22
Partials 3355 3355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…mccorm/updateCompat
…s/damccorm/updateCompat
|
R: @claudevdm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
claudevdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
When we use a lambda in a Beam.Map transform, the line number is included in the transform name. As a result, any change to the line number (including modifying other things in the file) changes the transform name, which breaks update compatibility.
This change pins some transforms to the names which they had during the 2.68 release. This logic is defined here -
beam/sdks/python/apache_beam/transforms/ptransform.py
Line 1143 in bd5cfda
This takes care of all the transforms in the apache_beam/transforms directory. After this is in, I'll follow up and handle this for more directories.
The line numbers are based on the release-2.68 branch, which can be seen here - https://github.com/apache/beam/tree/release-2.68/sdks/python/apache_beam/transforms
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.