Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 3, 2025

When we use a lambda in a Beam.Map transform, the line number is included in the transform name. As a result, any change to the line number (including modifying other things in the file) changes the transform name, which breaks update compatibility.

This change pins some transforms to the names which they had during the 2.68 release. This logic is defined here -

if fn.__name__ == '<lambda>':

This takes care of all the transforms in the apache_beam/transforms directory. After this is in, I'll follow up and handle this for more directories.

The line numbers are based on the release-2.68 branch, which can be seen here - https://github.com/apache/beam/tree/release-2.68/sdks/python/apache_beam/transforms


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the clarity and debuggability of Apache Beam pipelines by systematically applying explicit labels to Map transforms that previously lacked them. By providing descriptive names for these pipeline steps, especially those involving anonymous lambda functions, the changes will lead to a more intuitive visualization of data flows. This initial phase concentrates on the transforms directory, laying the groundwork for similar improvements across other components.

Highlights

  • Enhanced Pipeline Readability: Explicit labels have been added to numerous previously unlabeled Map transforms across core and utility functions within the transforms directory.
  • Improved Debugging and Visualization: The new labels, often generated from the lambda function's source location (e.g., "Map()"), will significantly improve the clarity of pipeline graphs, making them easier to understand and debug.
  • Targeted Transform Directory: This pull request specifically focuses on Map transforms within the sdks/python/apache_beam/transforms directory, with a follow-up planned to address IOs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the python label Oct 3, 2025
@damccorm
Copy link
Contributor Author

damccorm commented Oct 3, 2025

For a reviewer - please fact check that I got the line numbers right based on the release-2.68 branch and the file names right.

@damccorm damccorm marked this pull request as draft October 3, 2025 16:06
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.20%. Comparing base (3534960) to head (729a8d5).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/transforms/util.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36381      +/-   ##
============================================
- Coverage     40.20%   40.20%   -0.01%     
  Complexity     3386     3386              
============================================
  Files          1220     1220              
  Lines        186149   186175      +26     
  Branches       3523     3523              
============================================
+ Hits          74839    74843       +4     
- Misses       107955   107977      +22     
  Partials       3355     3355              
Flag Coverage Δ
python 40.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm marked this pull request as ready for review October 6, 2025 18:13
@damccorm
Copy link
Contributor Author

damccorm commented Oct 6, 2025

R: @claudevdm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Collaborator

@claudevdm claudevdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 9076b1a into master Oct 6, 2025
131 of 137 checks passed
@damccorm damccorm deleted the users/damccorm/updateCompat branch October 6, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants