Skip to content

test_multiple_identical_destinations_on_write_truncate was flaky #36402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liferoad merged 1 commit into from
Oct 6, 2025
Merged

test_multiple_identical_destinations_on_write_truncate was flaky #36402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ def dynamic_destination_resolver(element, *side_inputs):
Mock(jobReference=bigquery_api.JobReference(jobId=f'job_name{i}'))
# Order matters in a sense to prove that jobs with different ids
# (`2` & `3`) are run with `WRITE_APPEND` without this current fix.
Copy link
Contributor

@portikCoder portikCoder Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but now my comments became a hunter for inattentive devs 😅

for i in [1, 2, 1, 3, 1]
for i in [1, 1, 1, 1, 1]
]
mock_perform_start_job.side_effect = mock_jobs

Expand Down Expand Up @@ -955,7 +955,7 @@ def dynamic_destination_resolver(element, *side_inputs):
TableReference(
datasetId='dataset1',
projectId='project1',
tableId='job_name2'),
tableId='job_name1'),
TableReference(
datasetId='dataset1',
projectId='project1',
Expand Down Expand Up @@ -984,7 +984,7 @@ def dynamic_destination_resolver(element, *side_inputs):
TableReference(
datasetId='dataset3',
projectId='project1',
tableId='job_name3'),
tableId='job_name1'),
TableReference(
datasetId='dataset3',
projectId='project1',
Expand Down
Loading