Skip to content

Conversation

@stankiewicz
Copy link
Contributor

cloudsql_it_test.py::TestCloudSQLPostgresEnrichment::test_sql_enrichment_with_redis was broken as fixture was referencing fields set during setupClass method, that is invoked after fixture.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific test failure in cloudsql_it_test.py related to the order of execution between test fixtures and the setUpClass method. By adjusting the initialization of the _cache_client_retries class attribute, it ensures that necessary test configurations are available at the correct time, resolving a previously broken test case.

Highlights

  • Test Fix: Corrected an issue where a test fixture was referencing fields that were not yet initialized because setUpClass was invoked after the fixture.
  • Initialization Order: Moved the _cache_client_retries attribute initialization from the setUpClass method to a class-level attribute in BaseTestSQLEnrichment to ensure it's available when fixtures run.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the python label Oct 6, 2025
@stankiewicz stankiewicz changed the title fixture runs before setupclass [Python] cloudsql_it_test fixture runs before setupclass Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.17%. Comparing base (9cd994e) to head (e67aaf0).
⚠️ Report is 58 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #36406       +/-   ##
=============================================
- Coverage     56.84%   40.17%   -16.67%     
  Complexity     3386     3386               
=============================================
  Files          1220     1220               
  Lines        185898   186135      +237     
  Branches       3523     3523               
=============================================
- Hits         105672    74783    -30889     
- Misses        76885   108011    +31126     
  Partials       3341     3341               
Flag Coverage Δ
python 40.54% <ø> (-40.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liferoad liferoad merged commit 0b9fe99 into apache:master Oct 6, 2025
101 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants