Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 6, 2025

Fix #35627

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 6, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Oct 6, 2025

beam_PostCommit_Java_Examples_Dataflow_Java: https://github.com/apache/beam/actions/runs/18286174083/job/52061661440

beam_PostCommit_Java_Examples_Dataflow_ARM: https://github.com/apache/beam/actions/runs/18290156063

beam_PostCommit_Java_Examples_Dataflow_V2_Java: https://github.com/apache/beam/actions/runs/18290257189

beam_PostCommit_Java_ValidatesRunner_Dataflow_JavaVersions: https://github.com/apache/beam/actions/runs/18297391474/job/52098424890

beam_PostCommit_Java_ValidatesRunner_Direct_JavaVersions: https://github.com/apache/beam/actions/runs/18286182845

@github-actions github-actions bot added the io label Oct 6, 2025
@Abacn Abacn marked this pull request as ready for review October 6, 2025 19:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Oct 7, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Assigning reviewers:

R: @m-trieu for label java.
R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Oct 7, 2025

PreCommit Java PVR Prism Loopback failed 3 times:

testComposedCombineWithContext

java.lang.AssertionError: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.RuntimeException: The Runner experienced the following error during execution:
bundle inst012 stage-012 failed:org.apache.beam.sdk.util.UserCodeException: java.util.NoSuchElementException: Empty PCollection accessed as a singleton view.
	at org.apache.beam.sdk.util.UserCodeException.wrap(UserCodeException.java:39)
...
Caused by: java.util.NoSuchElementException: Empty PCollection accessed as a singleton view.
	at org.apache.beam.sdk.values.PCollectionViews$SingletonViewFn2.getDefaultValue(PCollectionViews.java:518)
	at org.apache.beam.sdk.values.PCollectionViews$SingletonViewFn2.apply(PCollectionViews.java:545)

checked that the same test also failing in other unrelated PRs (e.g. https://github.com/apache/beam/actions/runs/18231655679/job/51916196342). Also checked the same test passed locally when running the test alone, appears to be a flaky test

@Abacn
Copy link
Contributor Author

Abacn commented Oct 7, 2025

R: @Amar3tto @damccorm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, just had one question (doesn't need to be handled here, but should be an easy cleanup). Feel free to merge without addressing or after addressing

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Abacn Abacn merged commit d82f4fb into master Oct 7, 2025
33 checks passed
@Abacn Abacn deleted the java25example branch October 7, 2025 20:07
@Abacn Abacn restored the java25example branch October 8, 2025 21:17
@Abacn Abacn deleted the java25example branch October 8, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Java 25

2 participants