Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 7, 2025

The following error appears when running ./gradlew :examples:java:execute

* What went wrong:
A problem occurred evaluating script.
> Could not set unknown property 'preCommitRunners' for project ':examples:java' of type org.gradle.api.Project.

Please add a meaningful description for your change here

broken after #36255


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR refactors Gradle build scripts for Java examples by centralizing pre-commit runner configurations into a common Gradle file and removing duplicated code, addressing a breakage introduced by a prior change.

Highlights

  • Intent: This pull request aims to fix a broken Gradle task for executing examples, which was introduced by a previous change (Fix Build Issues with Iceberg Upgrade #36255). The core issue seems to be related to how pre-commit runner configurations are defined and shared across example projects.
  • Changes Summary: The primary change involves refactoring the definition of pre-commit runners and their associated configurations. Previously, this logic was duplicated in examples/java/build.gradle, examples/java/iceberg/build.gradle, and examples/java/sql/build.gradle. This PR moves this common configuration into examples/java/common.gradle and makes the runner lists (preCommitRunners, nonPreCommitRunners) accessible as project extensions (project.ext). Additionally, the execute task definition was removed from examples/java/sql/build.gradle, likely indicating it's now handled by the common script or is no longer needed in that specific context.
  • Reviewer Activity Summary: No reviewer activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Oct 7, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Assigning reviewers:

R: @robertwb for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Contributor

liferoad commented Oct 7, 2025

R: @tarun-google

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@tarun-google
Copy link
Contributor

LGTM

@Abacn Abacn merged commit e8b41d7 into apache:master Oct 7, 2025
19 of 20 checks passed
@Abacn Abacn deleted the fix-exec branch October 7, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants