Skip to content

Conversation

@stankiewicz
Copy link
Contributor

add setup to BigQuery's convert row Map transform


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the StorageWriteToBigQuery transform in Apache Beam's Python SDK by optimizing how BigQuery schemas are handled during the conversion of dictionaries to Beam Rows. By introducing a dedicated setup mechanism for schema preparation, it centralizes and streamlines the process, ensuring that schemas are correctly formatted and efficiently passed to the row conversion logic. This change improves the robustness and potential performance of BigQuery write operations.

Highlights

  • Schema Setup Optimization: Introduced a new nested class, ConvertToBeamRowsSetupSchema, to manage and prepare BigQuery schemas efficiently during the setup phase of the _BigQueryConvertDictToBeamRow transform.
  • Integration with DoFn.SetupContextParam: Modified the beam.Map transforms within _BigQueryConvertDictToBeamRow to leverage DoFn.SetupContextParam. This ensures that the schema is processed once at setup time by ConvertToBeamRowsSetupSchema and then passed to the beam_row_from_dict function, avoiding redundant schema conversions per element.
  • Consistent Schema Handling: The ConvertToBeamRowsSetupSchema now checks if the provided schema is already a bigquery.TableSchema or bigquery.TableFieldSchema and converts it using bigquery_tools.get_bq_tableschema if it's a different type, ensuring a standardized schema format for row conversion.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@stankiewicz
Copy link
Contributor Author

Run Python_ML PreCommit 3.13

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@stankiewicz
Copy link
Contributor Author

failures unrelated.
tested with pytest -v --capture=no apache_beam/io/external/xlang_bigqueryio_it_test.py::BigQueryXlangStorageWriteIT::test_write_with_dicts_cdc --test-pipeline-options='--runner=TestDirectRunner ---project=xxxx

@stankiewicz
Copy link
Contributor Author

Run Python_Dataframes PreCommit

@liferoad liferoad requested a review from ahmedabu98 October 20, 2025 15:53
@ahmedabu98
Copy link
Contributor

Can you add some motivation behind this change?

@stankiewicz
Copy link
Contributor Author

sure, @ahmedabu98 ,
"Convert dict to Beam Row" transform is Map per per element transform that invokes
bigquery_tools.beam_row_from_dict(element, schema).

if schema call is string or dict, it invokes conversion dict -> json string -> bigquery.TableSchema. Conversion happens for every element and it's expensive.

Change here is to add to Map transform the SetupContextParam parameter that will invoke conversion once.

Previous attempt (#36393) was reverted due to proto serialization issues.

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98 ahmedabu98 merged commit 7e7d866 into apache:master Oct 21, 2025
135 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants