revert outputWindowedValue changes as there is outputBuilder

[stankiewicz]

reverts and simplifies #35739

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline and simplify the element output mechanism within Apache Beam's Java SDK. By reverting specific outputWindowedValue changes and promoting the outputBuilder pattern, it removes redundant method overloads that explicitly handled record IDs and offsets. This refactoring enhances API consistency and maintainability across core runners, SDK components, and I/O connectors like KafkaIO.

Highlights

• Reversion of Output Methods: This pull request reverts previous changes related to outputWindowedValue methods, specifically those that directly accepted currentRecordId and currentRecordOffset parameters.
• Standardization with OutputBuilder: The changes standardize the output mechanism by consistently leveraging the outputBuilder pattern across various components of the Apache Beam Java SDK and its runners.
• API Simplification: Multiple output and outputWindowedValue method overloads that included currentRecordId and currentRecordOffset have been removed from DoFn.FinishBundleContext, DoFn.ProcessContext, and their implementations, simplifying the API.
• KafkaIO Update: The KafkaIO connector has been updated to reflect these changes, now using the OutputReceiver.builder() pattern for outputting elements with record IDs and offsets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

R: @kennknowles

[stankiewicz]

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[kennknowles]

Nice!

[Abacn]

It removed public facing API, as reflected by the change here, persumably user used to use ProcessContext.outputWindowedValue also gets affected. Shall we update CHANGES.md?

beam/CHANGES.md

Line 92 in ed39503

* (Java) DoFn OutputReceiver now requires implementing a builder method as part of extended metadata support for elements ([#34902](https://github.com/apache/beam/issues/34902)).

[Abacn]

checked that this was introduced in Beam 2.68.0 (c155a39)

[stankiewicz]

I will update changes.md - api was used to expose offset functionality that had limited usage so I don't expect it will affect anyone.

[stankiewicz]

#36530