Skip to content

Conversation

@aIbrahiim
Copy link
Contributor

Fixes: #33834

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is focused on expanding Apache Beam's compatibility by adding support for Python 3.13 in its Machine Learning container images. It achieves this by introducing a new, autogenerated requirements file that specifies all the necessary Python package dependencies, thereby enabling the use of Beam's ML capabilities with the latest Python version and resolving a previously identified issue.

Highlights

  • New Python 3.13 ML Container Support: This pull request introduces the necessary requirements file to support Python 3.13 for Machine Learning containers within Apache Beam.
  • Dependency Management: A new base_image_requirements.txt file has been added, listing all the Python package dependencies required for the py313 ML container image, ensuring consistency and reproducibility.
  • Issue Resolution: This change directly addresses and fixes issue The Republish Released Docker Images job is flaky #33834, which likely pertained to the absence of this crucial dependency file for Python 3.13 ML environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Amar3tto Amar3tto requested a review from damccorm October 28, 2025 14:33
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damccorm damccorm merged commit bcf41e1 into apache:master Oct 28, 2025
95 of 103 checks passed
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.10%. Comparing base (4e0dbb9) to head (7cc4d75).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #36647       +/-   ##
=============================================
+ Coverage     36.24%   55.10%   +18.85%     
  Complexity     1666     1666               
=============================================
  Files          1060     1059        -1     
  Lines        165700   165723       +23     
  Branches       1195     1195               
=============================================
+ Hits          60063    91325    +31262     
+ Misses       103461    72222    -31239     
  Partials       2176     2176               
Flag Coverage Δ
python 80.97% <ø> (+40.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aIbrahiim aIbrahiim deleted the 33834-Released-Docker-Images branch November 17, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Republish Released Docker Images job is flaky

2 participants