Enable some more tests in runner v2 batch mode.

[shunping]

Background: #20666 (comment)

I discovered that some state tests are actually skipped on Dataflow Runner V2 batch mode.

By re-enabling two previously excluded categories: UsesOnWindowExpiration and UsesStatefulParDo, we let ~50 more tests run in the post-commit workflow.

However, there are two GroupIntoBatches tests failed after this, which needs further investigation.

[gemini-code-assist]

Summary of Changes

Hello @shunping, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the robustness of the Dataflow V2 runner by re-integrating specific test categories that were previously excluded. By enabling tests for window expiration and stateful ParDo operations, the change ensures more comprehensive validation of these critical functionalities within the V2 runner's batch processing capabilities.

Highlights

• Test Enablement: Two previously excluded test categories, 'UsesOnWindowExpiration' and 'UsesStatefulParDo', have been re-enabled for the 'validatesRunnerV2Test' task in the Dataflow V2 runner. This expands the test coverage for batch mode operations.
• CI Trigger: A minor, trivial change was made to a GitHub trigger file to ensure the associated CI pipeline for the Dataflow V2 validation tests is initiated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[shunping]

Ok. Only two tests failed after enabling back categories: org.apache.beam.sdk.testing.UsesOnWindowExpiration and org.apache.beam.sdk.testing.UsesStatefulParDo

DataflowRunnerTest > testBatchGroupIntoBatchesOverrideBytes FAILED
    java.lang.AssertionError at DataflowRunnerTest.java:2286

DataflowRunnerTest > testBatchGroupIntoBatchesOverrideCount FAILED
    java.lang.AssertionError at DataflowRunnerTest.java:2212

Both of them failed with java.lang.AssertionError.

However, this change also increase the number of tests running with this post-commit test task from 241 to 290, which includes the tests for states.

Before:

After:

[github-actions]

Assigning reviewers:

R: @chamikaramj added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[chamikaramj]

LGTM. Thanks!

[ATHARVA262005]

Hi @chamikaramj and @shunping ,

I’ve been investigating the two GroupIntoBatches assertion failures mentioned in this PR (related to #37371). I found that the issue stems from the DataflowRunner translation skipping overrides for the V2/Unified Worker path in Batch mode.

I have submitted a root-cause fix in #37402. With that fix, the two tests currently being skipped in this PR should pass successfully. Perhaps it’s worth reviewing the fix in #37402 so we can re-enable these tests properly instead of skipping them here.

Thanks for the context in the PR description—it really helped me narrow down the search!