-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-3456] Enable jenkins and large scale scenario in JDBC #4392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run seed job |
|
Run Java JdbcIO Performance Test |
|
Run seed job |
|
Run Java JdbcIO Performance Test |
|
https://builds.apache.org/job/beam_PerformanceTests_JDBC/217/console Jenkins failed. I'm having one of the issues with jenkins from HadoopInputFormatIOIT PR: #4332 I think it is the path to kube config in both cases. @jbonofre could you help with determining what should be the path to kubeconfig file? We don't know the jenkins setup. |
|
Thanks ! Sure, gonna take a look. |
|
Can you try running in Jenkins executor 'beam1' ? It's possible that kubectl is only available in 'beam1'. See https://issues.apache.org/jira/browse/INFRA-14819. (I'm not sure if Apache infra acted on this after my last ping) Following config shows how to restrict execution to a given set of Jenkins executors. |
|
Run seed job |
|
Run Java JdbcIO Performance Test |
1 similar comment
|
Run Java JdbcIO Performance Test |
|
BTW are we assuming that there's an already running Kubernetes cluster in Jenkins with a proper kubeconfig ? This might not be the case. Does it make a difference if we try to run the Jenkins test against a Kubernetes cluster running in GKE ? cc: @jasonkuster |
The kubernetes infrastructure that is needed for the Jenkins job to run is not available for now. We should add it once the infrastructure is there.
That's right: we need kubectl and kubeconfig present on all jenkins executors given the previous JDBC test runs. Those indeed seems not to be there yet as @chamikaramj mentioned. Seems that we need to provide all this before we add the jenkins job. By "all this", I mean:
Given the kubernetes problems and other jenkins problems (the "permission denied" problem mentioned in JIRA 3480) I decided not to enable the jdbc job again yet (hence new commit, reverting the file change). Still the test can be run manually using io-it-suite/io-it-suite-local profiles on any kubernetes cluster, locally. This is still valueable. Let's add the jenkins job in a separate PR while kubernetes is setup properly on jenkins and jenkins itself works properly. @jasonkuster Could you help with setting the proper kubernetes infrastructure? |
|
SGTM. I'll review the PR without Jenkins updates. @alanmyrvold might be able to help with setting up a GKE-based Kubernetes cluster for I/O ITs. |
|
LGTM |
* apache#4378 - Field Path * review changes * 2nd review changes * 3rd review changes
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.This one allows JDBC to utilize the numberOfRecords pipeline option too, so that tests of different scale are possible.
Note that:
@iemejia @chamikaramj could you take a look?