CompressedSourceTest: simplify #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use random.nextBytes(buff) instead of making the array in a loop. The code we now point to is the same as the for loop, so the test continues to pass.
Contributor
Author
|
This change also fixes a build break in our integration tests which use a very strict compiler that disallows error-prone code. |
Contributor
Author
|
R: @tgroh |
Member
|
LGTM |
lukecwik
referenced
this pull request
in lukecwik/incubator-beam
Oct 13, 2016
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use random.nextBytes(buff) instead of making the array in a loop.
The code we now point to is the same as the for loop, so the test continues to pass.