Skip to content

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented Feb 1, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@iemejia iemejia requested a review from jbonofre February 1, 2018 14:29
@iemejia
Copy link
Member Author

iemejia commented Feb 1, 2018

netty version conflict as fixed before for the examples.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm merging. Thanks.

@jbonofre jbonofre merged commit cd0fb51 into apache:master Feb 6, 2018
@iemejia iemejia deleted the BEAM-3592-nexmark-spark-fix branch February 6, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants