Skip to content

[BEAM-3598][BEAM-3599][BEAM-3605] Sickbay flaky KinesisIO tests #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennknowles merged 1 commit into from
Feb 6, 2018
Merged

[BEAM-3598][BEAM-3599][BEAM-3605] Sickbay flaky KinesisIO tests #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/ShardReadersPoolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.List;
import java.util.concurrent.TimeUnit;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
Expand Down Expand Up @@ -158,6 +159,7 @@ public void shouldInterruptKinesisReadingAndStopShortly()
}

@Test
@Ignore("https://issues.apache.org/jira/browse/BEAM-3599")
public void shouldInterruptPuttingRecordsToQueueAndStopShortly()
throws TransientKinesisException, KinesisShardClosedException {
when(firstIterator.readNextBatch()).thenReturn(asList(a, b, c));
Expand Down Expand Up @@ -230,6 +232,7 @@ public void shouldStopReadersPoolWhenLastShardReaderStopped() throws Exception {
}

@Test
@Ignore("https://issues.apache.org/jira/browse/BEAM-3598")
public void shouldStopReadersPoolAlsoWhenExceptionsOccurDuringStopping() throws Exception {
when(firstIterator.readNextBatch()).thenThrow(KinesisShardClosedException.class);
when(firstIterator.findSuccessiveShardRecordIterators())
Expand All @@ -256,6 +259,7 @@ public void shouldReturnAbsentOptionalWhenStartedWithNoIterators() throws Except
}

@Test
@Ignore("https://issues.apache.org/jira/browse/BEAM-3605")
public void shouldForgetClosedShardIterator() throws Exception {
when(firstIterator.readNextBatch()).thenThrow(KinesisShardClosedException.class);
when(firstIterator.findSuccessiveShardRecordIterators())
Expand Down