Test: Py3.6 flake8 --select=E901,E999,F821,F822,F823 #4610
Conversation
|
@aaltay None of my Jenkins builds seem to succeed: https://github.com/apache/beam/pulls/cclauss Can you please help me understand if I am doing something wrong. |
|
Hi @cclauss, I looked at the errors and filed a few JIRA issues. Thank you for doing this, I believe we need to resolve the following issues to unblock this PR: https://issues.apache.org/jira/browse/BEAM-3669 - lint error most likely unrelated to your change. |
|
retest this please |
Run flake8 on Python 3 to find syntax errors and undefined names. __--exit-zero__ treats _all_ errors as warnings.
holdenk
left a comment
holdenk
left a comment
There was a problem hiding this comment.
I'm not sure we want to treat all errors as warnings? It seems like it might be better to slowly add the flake8 tests we have fixed and treat the errors as errors so we don't regress by mistake.
sdks/python/tox.ini
Outdated
| passenv = TRAVIS* | ||
|
|
||
| [testenv:py36] | ||
| # autocomplete_test depends on nose when invoked directly. |
There was a problem hiding this comment.
I don't think this comment is relevant for this env.
|
@holdenk Thanks as always for your wise counsel. I was just trying to get these tests to be run at all by Jenkins so that others would see what I am seeing locally. I have been trying to progress your futurize work but in smaller chunks. Now that I see how difficult it is to provision Python 3 in the Jenkins environment, I believe that keeping changes relatively small is the way to make steady progress. We can tighten the screws as you recommend after we can actually run tests under Python 3. |
|
Mostly fixed in #4376 |
4 participants
Run flake8 on Python 3 to find syntax errors and undefined names. --exit-zero treats all errors as warnings.