Skip to content

Conversation

@davidcavazos
Copy link

Fixing streaming samples to work in latest version. Basically just changed to use beam.io.WriteToBigQuery instead of using BigQuerySink. With this, it works both on DirectRunner and DataflowRunner. Also got rid of the WriteToBigQuery wrapper class, so a some of the code got simplified even further.

R: @aaltay

@aaltay
Copy link
Member

aaltay commented Feb 16, 2018

LGTM. Thank you.

@aaltay aaltay merged commit dfbdcbf into apache:master Feb 16, 2018
charlesccychen added a commit to charlesccychen/beam that referenced this pull request Mar 10, 2018
That change broke execution of hourly_team_score.
charlesccychen added a commit to charlesccychen/beam that referenced this pull request Mar 10, 2018
That change broke execution of hourly_team_score.
robertwb added a commit that referenced this pull request Mar 10, 2018
CP #4846 (Revert #4666 "Use beam.io.WriteToBigQuery()")
aaltay added a commit that referenced this pull request Mar 10, 2018
@davidcavazos davidcavazos deleted the game-streaming branch June 4, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants