Skip to content

Conversation

@kennknowles
Copy link
Member

The optional dependencies of elasticsearch-hadoop, pulled in by hadoop-input-format, appear to be getting fetched by Gradle. For some reason we have explicitly excluded three of them (also in the Maven config) even though they should already be left out. To fix the build, this explicitly excludes those that I have seen flake.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • [n/a] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [n/a] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

@lukecwik

@kennknowles kennknowles requested a review from lukecwik February 16, 2018 23:20
@kennknowles kennknowles changed the title Explicitly exclude some troublesome optional deps [BEAM-3715] Explicitly exclude some troublesome optional deps Feb 16, 2018
@kennknowles
Copy link
Member Author

I actually introduced flagrant style violations into master and it has no effect on the spotlessJavaCheck. From what I can tell spotless actually does not do anything in our build at the moment. The checkstyleMain and checkstyleTest are the things that actually check the formatting.

@kennknowles
Copy link
Member Author

Thus having an empty spotless { java { } } versus just applying the plugin, or whatever, doesn't really matter. I would suggest removing the plugin for now unless you know something that is not obvious here.

@lukecwik
Copy link
Member

I think your above comments are for the wrong PR.

testCompile "io.netty:netty-transport-native-epoll:4.1.0.CR3"
testCompile "org.elasticsearch:elasticsearch:$elastic_search_version"
testCompile ("org.elasticsearch:elasticsearch-hadoop:$elastic_search_version") {
// These are all optional deps of elasticsearch-hadoop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO with JIRA issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kennknowles
Copy link
Member Author

Yea, got my tabs mixed up it seems. Lots of gradle fixes waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants