[BEAM-3565] Break fusion for a ParDo which has State or Timers #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because these are provided in a key-partitioned manner, the upstream stage has to preserve keys for this to be executable. This could be checked, but this is a simpler method to break fusion when it is known it will be appropriate.
lukecwik
approved these changes
Feb 21, 2018
Member
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
Made minor comment change and will merge.
| public void materializesWithConsumerWithTimer() { | ||
| // (impulse.out) -> parDo -> (parDo.out) | ||
| // (parDo.out) -> timer -> timer.out | ||
| // timer has a state spec which prevents it from fusing with an upstream ParDo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because these are provided in a key-partitioned manner, the upstream
stage has to preserve keys for this to be executable. This could be
checked, but this is a simpler method to break fusion when it is known
it will be appropriate.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.