[BEAM-3538] Remove (or merge) Java 8 specific tests module into the main one #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
approved these changes
Feb 20, 2018
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, I thought it was already done. Thanks ! I will merge when Jenkins will be happy.
jbonofre
requested changes
Feb 20, 2018
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
Can you please resolve the conflict ?
aromanenko-dev
force-pushed
the
BEAM-3538-Java8-tests
branch
from
db78656 to
4a9e71c
Compare
Contributor
Author
|
@jbonofre Thanks! Sure, it's resolved and pushed, let's wait for Jenkins. |
aromanenko-dev
force-pushed
the
BEAM-3538-Java8-tests
branch
from
4a9e71c to
03764d6
Compare
iemejia
approved these changes
Feb 22, 2018
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM, all tests pass after the rebase so considering that JB also LGTMed I am merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Beam recently moved to Java 8 then we don't need to have dedicated module
java8testsfor that.All tests from this module moved to corresponding test classes and module
java8testswas deleted.Also, it was added an annotation
@Category(ValidatesRunner.class)or@Category(NeedsRunner.class)for those test where it was needed.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.