[BEAM-1866] Plumbing Gauge metrics through the Fn API. #4719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Run Python PostCommit |
Member
|
This LGTM. I am going to merge it even though I haven't dipped into this code too much, since it fixes build breakage on |
Contributor
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks Pablo and Ken. I have a minor functionality comment.
|
|
||
| @staticmethod | ||
| def from_runner_api(proto): | ||
| gauge_timestamp = proto.timestamp.seconds + proto.timestamp.nanos / 10**9 |
Contributor
There was a problem hiding this comment.
It looks like this could be doing a truncating division so that the resulting gauge_timestamp is an integer and drops the nanosecond values. Do we want to preserve nanoseconds by potentially doing something like float(proto.timestamp.nanos) before doing the division?
Member
Author
There was a problem hiding this comment.
You are correct Charles. I'll get that fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the necessary protos and logic to plumb Gauge metrics through the Fn API.
r: @charlesccychen