-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-3217] Jenkins job for HadoopInputFormatIOIT #4758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f29eb79 to
e5b6fd7
Compare
|
Run seed job |
|
Run Java HadoopInputFormatIO Performance Test |
bc16e32 to
4b0a07f
Compare
|
Run seed job |
4b0a07f to
acd0ba7
Compare
|
Run seed job |
|
Run Java HadoopInputFormatIO Performance Test |
acd0ba7 to
1477e0f
Compare
|
Run seed job |
|
Run Java HadoopInputFormatIO Performance Test |
Previously, when two tests were using same postrgres kubernetes scripts, one of the tests failed, because there "already is a postgres instance". Adding namespaces and using kubeconfig per test run isolates the runs and they do not interfere now.
1477e0f to
74de104
Compare
|
Run seed job |
|
Run Java HadoopInputFormatIO Performance Test |
|
@chamikaramj sorry for the above mess in comments - I had to run this on Jenkins properly. Now it's ready for review. Could you please take a look? |
|
Run Java JdbcIO Performance Test |
|
Run seed job |
|
Run Java HadoopInputFormatIO Performance Test |
|
Run Java JdbcIO Performance Test |
|
I was able to confirm that HadoopInputFormat Performance test will fail due to dataflow runner issue as well. See the issue and [the logs].(https://builds.apache.org/job/beam_PerformanceTests_HadoopInputFormat/7/console) @chamikaramj could you take a look either way? |
|
Run seed job |
|
Run Java JdbcIO Performance Test |
|
Run Java HadoopInputFormatIO Performance Test |
|
Run seed job |
|
Retest this please |
|
LGTM. Merged. |
This PR adds jenkins jobs for HadoopInputFormatIOIT.
Before this PR there was only one test that used postgres kubernetes scripts (JDBC IOIT). Right now, while having more than one test using those, there is a strong possiblility that two tests will try to create kubernetes resources (eg. service or replication controller) of the same name (say, "postgres"). This will result in one test being unable to run successfully (due to names collision).
This PR proposes a solution to above problem. Every kubernetes test resource is being created in it's own namespace. This avoids the name collisions and allows running them "in isolation".
This solution has some other (minor) advantages:
kubectl delete namespace foo) it deletes it's "inner resources" too.Remarks:
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.