Skip to content

[BEAM-3738] Enable py3 lint #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaltay wants to merge 2 commits into from
Closed

[BEAM-3738] Enable py3 lint #4801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9ea28
Enable py3 lint
aaltay Mar 6, 2018
bad4a3c
Update tox.ini for lint py3
aaltay Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def generate_common_urns():
]),
setup_requires=REQUIRED_SETUP_PACKAGES,
install_requires=REQUIRED_PACKAGES,
python_requires='>=2.7,<3.0',
test_suite='nose.collector',
tests_require=REQUIRED_TEST_PACKAGES,
extras_require={
Expand Down
9 changes: 4 additions & 5 deletions sdks/python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@

[tox]
# new environments will be excluded by default unless explicitly added to envlist.
# TODO (after BEAM-3671) add lint_py3 back in.
envlist = py27,py27gcp,py27cython,lint_py2,docs
envlist = py27,py27gcp,py27cython,lint_py2,lint_py3,docs
toxworkdir = {toxinidir}/target/.tox

[pycodestyle]
Expand Down Expand Up @@ -103,7 +102,6 @@ whitelist_externals=time
commands =
python --version
pip --version
time pip install -e .[test]
time {toxinidir}/run_pylint.sh
passenv = TRAVIS*

Expand All @@ -116,12 +114,13 @@ deps=
isort==4.2.15
flake8==3.5.0
whitelist_externals=time
basepython=python3
commands =
time pip install -e .[test]
python --version
pip --version
time {toxinidir}/run_mini_py3lint.sh
passenv = TRAVIS*


[testenv:docs]
deps=
nose==1.3.7
Expand Down