Skip to content

[BEAM-3785][SQL] Add support for arrays #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennknowles merged 5 commits into from
Mar 10, 2018
Merged

[BEAM-3785][SQL] Add support for arrays #4802

kennknowles merged 5 commits into from
Mar 10, 2018

Conversation

@akedin
Copy link
Contributor

@akedin akedin commented Mar 6, 2018 •
edited
Loading

Add support for arrays, implement ARRAY creation and operations

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@akedin akedin changed the title [SQL] Add basic support for ARRAY expression [BEAM-3785][SQL] Add basic support for ARRAY expression Mar 6, 2018
@akedin
Copy link
Contributor Author

akedin commented Mar 6, 2018

R: @kennknowles @apilloud

@akedin akedin changed the title [BEAM-3785][SQL] Add basic support for ARRAY expression [BEAM-3785][SQL] Add basic support for arrays Mar 6, 2018
@akedin akedin changed the title [BEAM-3785][SQL] Add basic support for arrays [BEAM-3785][SQL] Add support for arrays Mar 6, 2018
akedin added 5 commits March 7, 2018 13:21
@akedin
[SQL] Add support for ARRAY expression
594d5e1 
Implement ARRAY creation
@akedin
[SQL] Support ARRAY in projections
925ca66 
Allow selecting arrays from existing rows
@akedin
[SQL] Implement array elements access expression
21a6c78 
Implement `array_field[i]`
@akedin
[SQL] Add support for ELEMENT(collection) function
581c5d1 
ELEMENT(collection) returns a single element from the collection
@akedin
[SQL] Add support for CARDINALITY(collection)
5e032cb 
CARDINALITY(collection) returns number of elements in the collection
@akedin akedin force-pushed the sql-array-support branch from 7ef08ed to 5e032cb Compare March 7, 2018 21:31
@kennknowles
Copy link
Member

kennknowles commented Mar 10, 2018

:lgtm: good to have this support in place. I expect that we will want to look at the performance of basically running a syntax-tree interpreter on every expression. Not new in this PR, but seeing the functionality added made me think of it. That's a slow approach in a tight loop.

Reviewed 3 of 11 files at r1, 17 of 17 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@kennknowles kennknowles merged commit be52069 into apache:master Mar 10, 2018
@apilloud apilloud mentioned this pull request Aug 29, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akedin @kennknowles