[BEAM-3806] Fix direct-runner hang #4829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2018 10:25
1. TimerUpdates should use an ordered collection so that the most recent timestamp set by user code is the one taken throughout the system. 2. Application of TimerUpdates needs to keep all three data structures in sync. 3. Add unit tests that the data structures are consistent.
tgroh
approved these changes
Mar 8, 2018
Contributor
Author
|
Run Java PreCommit |
Contributor
|
I think this broke Fix: #4849 |
bjchambers
added a commit
to bjchambers/beam
that referenced
this pull request
Mar 15, 2018
Fix handling of timers in WatermarkManager 1. TimerUpdates should use an ordered collection so that the most recent timestamp set by user code is the one taken throughout the system. 2. Application of TimerUpdates needs to keep all three data structures in sync. 3. Add unit tests that the data structures are consistent. Added ParDoTest hangs when run with the DirectRunner prior to the other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 adds a ParDo test that hangs the direct runner as described in BEAM-3806. Commit 2 fixes it.