Skip to content

[BEAM-81] --update PipelineOption is in the wrong interface #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swegner wants to merge 2 commits into from
Closed

[BEAM-81] --update PipelineOption is in the wrong interface #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7889e1
Move 'update' pipeline option to correct interface
swegner Feb 29, 2016
5b6c32a
Remove JsonIgnore attribute
swegner Mar 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,14 @@ public Dataflow create(PipelineOptions options) {

/**
* Whether to update the currently running pipeline with the same name as this one.
*
* @deprecated This property is replaced by @{link DataflowPipelineOptions#getUpdate()}
*/
@JsonIgnore
@Deprecated
@Description("If set, replace the existing pipeline with the name specified by --jobName with "
+ "this pipeline, preserving state.")
boolean getUpdate();
@Deprecated
void setUpdate(boolean value);

/**
Expand Down
13 changes: 13 additions & 0 deletions sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ public interface DataflowPipelineOptions extends
String getJobName();
void setJobName(String value);

/**
* Whether to update the currently running pipeline with the same name as this one.
*/
@Override
@SuppressWarnings("deprecation") // base class member deprecated in favor of this one.
@Description(
"If set, replace the existing pipeline with the name specified by --jobName with "
+ "this pipeline, preserving state.")
boolean getUpdate();
@Override
@SuppressWarnings("deprecation") // base class member deprecated in favor of this one.
void setUpdate(boolean value);

/**
* Returns a normalized job name constructed from {@link ApplicationNameOptions#getAppName()}, the
* local system user name (if available), and the current time. The normalization makes sure that
Expand Down