-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-374] Enable dependency-plugin and failOnWarning at global level. #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @amitsela for checking the correctness of the spark dependency. |
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.14</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version numbers should be inherited from root-level pom, I think. See grpc above, for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Added comments, mainly relating to @dhalperi comment on inheriting versions for root level pom (and some suggestions for additional once for Spark's pom). And how does this relate to removing beam-examples dependencies ? Why do we want to remove this dependency ? I would prefer a dependency to use beam-examples in the runner's tests on duplicating them. |
|
Users should be able to run beam-examples with any runners, and beam-examples will need runtime dependency to runners-spark. I cannot add that runtime dependency when runners-spark depends on beam-examples. Previously, runners-spark is pull dependency from other module, and runners-spark can be broken by dependency changes in other module (removing, changing version, and even adding). This is another benefits. |
|
Makes sense. Thanks for clarifying that! |
| @@ -861,15 +861,6 @@ | |||
| </plugin> | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment should move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@dhalperi PTAL, and merge if it looks good. Thanks |
|
LGTM. |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Fix xvr gojava
Spark dependency fix is included in this PR. This is to remove the beam-examples dependency from Spark.
failOnWarning is disabled for Flink for now.
The added dependencies in this PR come from "mvn dependency:analyze"