[BEAM-4009] Futurize unpackaged files #5387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdks/python/apache_beam/pvalue.py
Outdated
|
|
||
| def __init__(self, tag, value): | ||
| if not isinstance(tag, string_types): | ||
| if not isinstance(tag, (bytes, unicode)): |
Contributor
There was a problem hiding this comment.
six.string_types is equivalent to (str, unicode).
See https://pythonhosted.org/six/#six.string_types
On Python 2, bytes is an alias for str, but on Python 3 this will behave differently.
Contributor
|
LGTM, Thank you! |
Contributor
|
Could you please resolve the merge conflicts? |
aaltay
approved these changes
Jun 13, 2018
Member
Contributor
Author
|
run python precommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prepares the unpackaged files for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.
This approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.
R: @aaltay @tvalentyn @RobbeSneyders