Skip to content

Make hash function in Coder base class more conservative. #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tvalentyn wants to merge 1 commit into from
Closed

Make hash function in Coder base class more conservative. #5390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sdks/python/apache_beam/coders/coders.py → sdks/python/apache_beam/cod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,10 @@ def __repr__(self):
def __eq__(self, other):
return (self.__class__ == other.__class__
and self._dict_without_impl() == other._dict_without_impl())
# pylint: enable=protected-access

def __hash__(self):
return hash((self.__class__,) +
tuple(sorted(self._dict_without_impl().items())))
# pylint: enable=protected-access
return hash(type(self))

_known_urns = {}

Expand Down