[BEAM-3998] Futurize examples subpackage #5652
Conversation
Fematich
changed the title
|
Thank you. I will wait for @tvalentyn to make the first pass. |
| 'team': row[1], | ||
| 'score': int(row[2]), | ||
| 'timestamp': int(row[3]) / 1000.0, | ||
| 'timestamp': int(row[3]) // 1000.0, |
There was a problem hiding this comment.
This should be reguilar division given the float number.
| 'team': row[1], | ||
| 'score': int(row[2]), | ||
| 'timestamp': int(row[3]) / 1000.0, | ||
| 'timestamp': (int(row[3])//1000.0), |
There was a problem hiding this comment.
Same here. Also not sure why the tool added parenthesis on both sides.
| 'team': row[1], | ||
| 'score': int(row[2]), | ||
| 'timestamp': int(row[3]) / 1000.0, | ||
| 'timestamp': (int(row[3])//1000.0), |
| 'team': row[1], | ||
| 'score': int(row[2]), | ||
| 'timestamp': int(row[3]) / 1000.0, | ||
| 'timestamp': (int(row[3])//1000.0), |
| googledatastore.helper.add_key_path(entity.key, kind, str(uuid.uuid4())) | ||
| googledatastore.helper.add_properties(entity, | ||
| {'content': six.text_type(content)}) | ||
| {'content': unicode(content)}) |
There was a problem hiding this comment.
Several other modules in the examples package also use six, let's clean them up.
See: https://github.com/apache/beam/search?q=six.text_type&unscoped_q=six.text_type.
There was a problem hiding this comment.
I removed all the remaining six imports with the latest commit.
|
Thanks, @Fematich. Did you push the updated commit? I still see |
|
Sorry for that! Apparently I didn't push my latest commit, fixed now |
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thank you @Fematich. This LGTM.
[BEAM-3998] Futurize examples subpackage
[BEAM-3998] Futurize examples subpackage
4 participants
This pull request prepares the examples subpackage for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.
This approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.
R: @aaltay @tvalentyn @RobbeSneyders