Skip to content

[BEAM-3761] Define cmp() in Python 3 #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesccychen merged 2 commits into from
Jul 10, 2018
Merged

[BEAM-3761] Define cmp() in Python 3 #5843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9242ca
[BEAM-3761] Define cmp() in Python 3
Jun 30, 2018
779558e
[BEAM-3959] Add Python 3 undefined names to flake8
Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/python/apache_beam/transforms/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@

from google.protobuf import duration_pb2
from google.protobuf import timestamp_pb2
from past.builtins import cmp

from apache_beam.coders import coders
from apache_beam.portability import common_urns
Expand Down
3 changes: 1 addition & 2 deletions sdks/python/scripts/run_mini_py3lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,4 @@ if test $# -gt 0; then
fi

echo "Running flake8 for module $MODULE:"
# TODO(BEAM-3959): Add F821 (undefined names) as soon as that test passes
flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics
flake8 $MODULE --count --select=E9,F821,F822,F823 --show-source --statistics