-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-1251] Replace NameError-driven dispatch with past
#5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0bf9395 to
217e9a0
Compare
|
This is great stuff... Can you just try:
We still have Leave that 'buffer' one to me... I have nice progress on that one but all other are fair game. |
|
Will do. I can fix @cclauss also, can we merged futurization PRs first? |
|
Thank you @superbobry. Could you coordinate your changes with rest of the people working on python 3 changes on the mailing list. There was a recent reviewed proposal for python 3 conversion and some of the bits you are removing were added as part of it. You can find the proposal on the Beam web site: https://beam.apache.org/contribute/#python-3-support @tvalentyn could also help with coordination. (I noticed that you are already started coordinating on the mailing list. That is great, please share major planned changes, such as the use of |
|
Please resolve conflict. |
9d87f37 to
123d2d2
Compare
123d2d2 to
4141c0e
Compare
|
Thanks, @superbobry , this LGTM. I also ran this past coders microbenchmark in #5565 and did not see any performance impact. |
|
LGTM, thank you. |
The only leftover is the ``ToStringCoder`` which uses ``NameError`` to detect Python2/3. The logic there looks fishy (it encodes text data on 2.X but not on 3.X), so I'd rather address it in a follow up PR.
4141c0e to
ff2f571
Compare
|
Rebased on top of master. |
aaltay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for making this happen!
The only leftover is the
ToStringCoderwhich usesNameErrorto detect Python2/3. The logic there looks fishy (it encodes text data on 2.X but not on 3.X), so I'd rather address it in a follow up PR.Post-Commit Tests Status (on master branch)