Skip to content

[BEAM-4007] Fix TODO style in typehints.py #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesccychen merged 1 commit into from
Jul 3, 2018
Merged

[BEAM-4007] Fix TODO style in typehints.py #5872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/typehints/typehints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ def __repr__(self):
return 'Any'

def __hash__(self):
# TODO(BEAM - 3730)
# TODO(BEAM-3730): Fix typehints.TypeVariable issues with __hash__.
return hash(id(self))

def type_check(self, instance):
Expand All @@ -432,7 +432,7 @@ def __eq__(self, other):
return type(self) == type(other) and self.name == other.name

def __hash__(self):
# TODO(BEAM - 3730)
# TODO(BEAM-3730): Fix typehints.TypeVariable issues with __hash__.
return hash(id(self))

def __repr__(self):
Expand Down