Skip to content

[BEAM-1251] Upgrade from buffer to memoryview (again) #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesccychen merged 2 commits into from
Jul 8, 2018
Merged

[BEAM-1251] Upgrade from buffer to memoryview (again) #5887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
528754c
[BEAM-1251] Upgrade from buffer to memoryview (again)
Jul 4, 2018
7bf14e8
Merge branch 'master' into buffer-to-memoryview-again
charlesccychen Jul 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/io/avroio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ def _decompress_bytes(data, codec):

# Compressed data includes a 4-byte CRC32 checksum which we verify.
# We take care to avoid extra copies of data while slicing large objects
# by use of a buffer.
result = snappy.decompress(buffer(data)[:-4])
# by use of a memoryview.
result = snappy.decompress(memoryview(data)[:-4])
avroio.BinaryDecoder(io.BytesIO(data[-4:])).check_crc32(result)
return result
else:
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/container/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ RUN \
# Optional packages
pip install "cython == 0.28.1" && \
pip install "guppy == 0.1.10" && \
pip install "python-snappy == 0.5.1" && \
pip install "python-snappy == 0.5.3" && \
# These are additional packages likely to be used by customers.
pip install "numpy == 1.13.3" --no-binary=:all: && \
pip install "pandas == 0.18.1" && \
Expand Down