[BEAM-3959] Add Python 3 undefined names to flake8 #5901
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as apache#5843 and apache#5900 are closed, we should add F821 (undefined names) tests to the flake8 tests on Python 3. This should flag commits that contain unqualified past.builtin imports such as basestring, cmp, raw_input, reload, unicode, xrange, etc.
Author
|
Incorporated into PR #5843 |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* Replace links to '/stable/' with '/latest/'. * DRY out duplicated 'README.rst' vs. 'docs/index.rst'. * Include websecurityscanner in docs. Toward apache#5894.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as #5843
and #5900(or similar) are closed, we should add F821 (undefined names) to the flake8 tests on Python 3. This should flag commits that contain Python 2-only built-ins such as basestring, cmp, raw_input, reload, unicode, xrange, etc.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)