[BEAM-5663] Add Python 3.6 tox environment #7988
Conversation
RobbeSneyders
changed the title
| equal_to([(None, {'a': [1]})])) | ||
|
|
||
| @unittest.skipIf(sys.version_info >= (3, 6, 0) and | ||
| os.environ.get('RUN_SKIPPED_PY36_TESTS') != '1', |
There was a problem hiding this comment.
It is sufficient to have one variable RUN_SKIPPED_PY3_TESTS - we only need a way to override the skip decorator.
There was a problem hiding this comment.
Yes, you're right. Updated, thanks!
tvalentyn
left a comment
tvalentyn
left a comment
There was a problem hiding this comment.
Thanks, @RobbeSneyders , left one suggestion to simplify the change.
|
There is going to be a conflict with https://github.com/apache/beam/pull/7675/files, so it would be nice to merge this soon. |
|
(That was a message for @RobbeSneyders) |
RobbeSneyders
force-pushed
the
python3.6
branch
from
29cd558 to
d5936ae
Compare
RobbeSneyders
force-pushed
the
python3.6
branch
from
d5936ae to
ee41096
Compare
|
Run Python PreCommit |
3 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Run Python PreCommit |
| main | beam.Map(lambda a, b: (a, b), beam.pvalue.AsDict(side)), | ||
| equal_to([(None, {'a': [1]})])) | ||
|
|
||
| @unittest.skipIf(sys.version_info >= (3, 6, 0) and |
There was a problem hiding this comment.
Do we have Jira's for this and other failures? Could we reference it here?
Thanks.
| def assertReturnType(self, expected, f, inputs=()): | ||
| self.assertEquals(expected, trivial_inference.infer_return_type(f, inputs)) | ||
|
|
||
| @unittest.skipIf(sys.version_info >= (3, 6, 0) and |
There was a problem hiding this comment.
It may be easier to move the skip declaration to skip entire class TrivialInferenceTest.
|
We will merge this change to avoid resolving merge conflict with #7675, please add the JIRAs to excluded tests in a follow-up change. |
|
I'm going over tox.ini for a nose->pytest migration. I see that |
|
It's an oversight, thanks for calling out, @udim. Opened https://issues.apache.org/jira/browse/BEAM-8093 |
4 participants
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3.
This PR adds a tox test suite for Python 3.6.
Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.