Skip to content

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Sep 5, 2019

R: @chadrik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2019

Run Python PreCommit

@chadrik
Copy link
Contributor

chadrik commented Sep 5, 2019

Looks good!

This is really powerful stuff. I see now why you were disappointed by the lack of inference from mypy.

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2019

Thanks.

Yes, the inference here is not as powerful in some ways as the whole-program inference that mypy, etc. does, but for passing through types through simple lambdas (something very natural for Beam) it is quite useful.

@robertwb robertwb merged commit f747159 into apache:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants